balanced / balanced-api

Balanced API specification.
221 stars 72 forks source link

Wrap object creation. #501

Closed steveklabnik closed 10 years ago

steveklabnik commented 10 years ago

This change was one way that we weren't in line with the spec.

/cc @matthewfl

matthewfl commented 10 years ago

are we also going to have scenarios for when using just the application/json content type or for form content type, where wrapping the content of the request is not required?

steveklabnik commented 10 years ago

Yeah, form content type tests would be good. I'll make an issue that we're missing those.

steveklabnik commented 10 years ago

Restarting the build, let's see how this goes.

steveklabnik commented 10 years ago

Can you rebase this? I'm pretty sure that's why the tests still fail.

matthewfl commented 10 years ago

@steveklabnik was that last comment meant for me?

steveklabnik commented 10 years ago

yes.

mjallday commented 10 years ago

ping @matthewfl

steveklabnik commented 10 years ago

These tests are still failing because it says it isn't JSON.

matthewfl commented 10 years ago

"it"? the last time I worked on this the problem was the httpparty was passing everything as x-www-form instead of json

steveklabnik commented 10 years ago

Look at the error message. No clue, looks good to me. :(

matthewfl commented 10 years ago

There should be one tests that is failing, however it is unrelated to the wrapping of json and instead related to the address cracking issue which has already been noted

mahmoudimus commented 10 years ago

@matthewfl is this ready 2 go?

mahmoudimus commented 10 years ago

woot! thx @matthewfl