balanced / balanced-api

Balanced API specification.
221 stars 72 forks source link

Cannot include meta information with a POST Credit request #504

Closed joeenzminger closed 10 years ago

joeenzminger commented 10 years ago

In order to associate meta with a Credit, you must first create the credit with a POST and then update it with a PUT. The POST Credit API method should allow you to set the meta data immediately.

Version 1.1 API

mjallday commented 10 years ago

Thanks for the heads up @joeenzminger. We've got a fix coming through the pipeline for this now, I'll close this issue once it's resolved.

mjallday commented 10 years ago

curl https://api.balancedpayments.com/bank_accounts/BA4S3Kn2Tyor6hMJCe86BB5A/credits -H "Accept-Type: application/vnd.api+json;revision=1.1" -u ak-test-1sKqYrBZG6WYpHphDAsM7ZXFEmJlAn1GE: -d "amount=5000" -d "meta[foo]=bar"

{
  "credits": [
    {
      "status": "succeeded",
      "description": null,
      "links": {
        "customer": "CU4Qvf9NGWuN3PSjM8FQhJ4H",
        "destination": "BA4S3Kn2Tyor6hMJCe86BB5A",
        "order": null
      },
      "updated_at": "2014-02-03T17:50:17.407410Z",
      "created_at": "2014-02-03T17:50:16.435105Z",
      "transaction_number": "CR624-960-6653",
      "failure_reason": null,
      "currency": "USD",
      "amount": 5000,
      "failure_reason_code": null,
      "meta": {
        "foo": "bar"
      },
      "href": "/credits/CR4Z6MwGmzILV4uBrq3lKGTI",
      "appears_on_statement_as": "example.com",
      "id": "CR4Z6MwGmzILV4uBrq3lKGTI"
    }
  ],
  "links": {
    "credits.order": "/orders/{credits.order}",
    "credits.customer": "/customers/{credits.customer}",
    "credits.destination": "/resources/{credits.destination}",
    "credits.reversals": "/credits/{credits.id}/reversals",
    "credits.events": "/credits/{credits.id}/events"
  }
}

thanks @joeenzminger

joeenzminger commented 10 years ago

Confirmed fixed. Thanks!

mjallday commented 10 years ago

@joeenzminger we really appreciate the bug reports. Shoot us an email to support@balancedpayments.com if you'd like some swag to say thanks.