search

balanced / balanced-api

Balanced API specification.
221 stars 72 forks source link

CardHolds and Orders #508

Closed remear closed 9 years ago

remear commented 10 years ago

When working with an Order, how does a CardHold fit in? How is one associated to an Order? I don't see an order field for a CardHold. How should this work?

/cc @steveklabnik

mjallday commented 10 years ago

@steveklabnik I just fixed a bug where we were not associating holds to orders and I'm about to push out a fix. This doesn't resolve this issue since I did not expose the order in the hold's view since it would break the spec. It does however allow people to associate orders and holds.

I think you should also be able to associate an order to a hold after the hold is created so we should support that use-case.

Can you make the changes and let me know when there is a PR for it and I will implement the views and the PUT/PATCH behavior in the app.

mjallday commented 10 years ago

We've deployed some updates to the API such that you can now specify an order when creating or capturing a hold. e.g.

curl https://api.balancedpayments.com/cards/CC2Z3H6dHzC91s8hLPvN21Tq/card_holds -H "Accept: application/vnd.api+json;revision=1.1" -u ak-test-h7F8F3u41y6LzCK4nZeVd5BafaWOUuZL: -d "amount=5000" -d "order=/orders/OR3NpTvAqeJ3rgJvKRcC4evw" will associate the debit when it is created to the hold.

However, there is no "visual" confirmation as such. Neither the hold nor the order will show anything related to the hold. This requires the above mentioned change to the spec.

rserna2010 commented 9 years ago

This PR exposes the order link: https://github.com/balanced/balanced/pull/648, api spec change made accordingingly