balanced / balanced-api

Balanced API specification.
221 stars 72 forks source link

Remove 'Arbitration' state from the Disputes resource #537

Open tarunc opened 10 years ago

tarunc commented 10 years ago

It should be Lost instead.

@cieplak

matthewfl commented 10 years ago

Also status is suppose to just represent on of pending succeeded or failed so we should really rename this field to dispute_status or something

tarunc commented 10 years ago

Right now the status field of a dispute resource contains 4 states: Lost, Won, Pending, and Arbitration. The Arbitration state should not exist as these disputes are considered lost.

In my opinion, how it is right now makes sense, keeping the field named status because it is describing the status of the dispute resource but I can understand the reasoning behind changing the field name. Let me know if you end up renaming the status field to dispute_status.

matthewfl commented 10 years ago

@steveklabnik thoughts on the name of the field, we were at one point trying to be consistent with fields call status in rev 1.1 since in rev 1.0 there are different values that status can take on depending on which resource you are looking. So basically I am trying to avoid inconsistencies

steveklabnik commented 10 years ago

Yes, I like keeping the names consistent. :+1: for status.

Is there a difference between Arbitration and Lost, @cieplak ?

cieplak commented 10 years ago

Arbitration is a form of loss but is more of an implementation detail, so will update the interface to reflect this.

On Mon, Mar 24, 2014 at 10:34 AM, Steve Klabnik notifications@github.comwrote:

Yes, I like keeping the names consistent. [image: :+1:] for status.

Is there a difference between Arbitration and Lost, @cieplakhttps://github.com/cieplak?

Reply to this email directly or view it on GitHubhttps://github.com/balanced/balanced-api/issues/537#issuecomment-38475088 .

Patrick Cieplak Engineer @ Balanced

kyungmin commented 10 years ago

@cieplak Has this been updated?

remear commented 9 years ago

ping @cieplak