search

balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

Fixes balanced/balanced-docs#335 #556

Closed remear closed 10 years ago

steveklabnik commented 10 years ago

@matthewfl why did this get merged? The tests are failing.

matthewfl commented 10 years ago

@steveklabnik plz look at the test that are failing, they are unrelated, and if you run the test locally they pass

matthewfl commented 10 years ago

@steveklabnik plus master was already "failing" on the same test, however it just hadn't be rerun in a long enough time

steveklabnik commented 10 years ago

Yeah, I'm seeing it as intermittent now.

Why is the test failing every so often? Shouldn't we fix this flakiness of this before merging?

matthewfl commented 10 years ago

ben was saying on friday that sometime disputes where taking upto 10 minutes to show up, however when I was running the tests from the office ip it was always fast. However sometimes when I run it from different ips it doesn't alway show up in a timely fashion

remear commented 10 years ago

Hold up here. The tests I'm seeing fail were failing before I opened this PR and are always failing.

https://travis-ci.org/balanced/balanced-api/builds/22205687

One was report in https://github.com/balanced/balanced-api/issues/552. The other two look to be related to issues with the dispute tests.

steveklabnik commented 10 years ago

I'm not seeing any of those failures. Just one, intermittent failure around the dispute appearing