balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

CardHold void terminology #558

Closed remear closed 9 years ago

remear commented 10 years ago

The outcome of https://github.com/balanced/balanced-api/issues/489 was to void CardHolds with a DELETE. Do we need to update terminology accordingly?

See https://github.com/balanced/balanced-ruby/commit/cccbad19c146ca2587822411473ddb4556035b9f#commitcomment-5913885

Do we need to change the category code to 'hold-has-been-deleted' instead of 'hold-already-voided'?

Should the scenarios be "Delete a CardHold" instead of Void a CardHold?

My understanding is that we're using a delete operation to void the CardHold, but it's not actually deleted. It remains around for historical lookups.