search

balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

Scenarios don't pass #578

Closed matin closed 10 years ago

matin commented 10 years ago

The scenarios for the API don't pass and haven't for some time now: https://travis-ci.org/balanced/balanced-api/builds

What do we need to do to make sure the API validates against the scenarios before the API is deployed?

Who can fix the current broken scenarios and all of the ones that are skipped?

/cc @steveklabnik @mahmoudimus @remear @matthewfl

cieplak commented 10 years ago

We make sure the API validates against the spec before we deploy API resource changes. For instance, I have a deploy that's blocked right now on updating the spec to reflect my resource change. It's not strictly a requirement, however. We would solve this by making the API scenarios part of our acceptance tests, which would mean nothing would be deployed unless all the API specs were passing.

matin commented 10 years ago

@cieplak it's been 17 days since the scenarios were last passing. No one should have been able to deploy until the scenarios all passed.

steveklabnik commented 10 years ago

This is not getting fixed until at least next week: https://github.com/balanced/balanced-api/issues/591

matthewfl commented 10 years ago

https://travis-ci.org/balanced/balanced-api/builds/26806427 the master branch is currently passing.