balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

Scenario grammar should use "this matches" instead of "this match" #579

Closed matin closed 10 years ago

matin commented 10 years ago

This is confusing because it requires the person writing a scenario to use incorrect English grammar.

https://github.com/balanced/balanced-api/blob/master/features/step_definitions/http_steps.rb#L170-L173

Then(/^the fields on this (.*) match:$/) do |resource, against|
  checker JSON.parse(@client.hydrater(against)), @client["#{resource}s"], ''
  assert_equal @client.last_body["#{resource}s"].size, 1
end

Fixing this issue also requires correcting all of the scenarios that uses this check.

msherry commented 10 years ago

Not sure what you mean.

"The fields on this card match..." is correct. "The fields on this account matches..." is incorrect.

matin commented 10 years ago

I stand corrected.

@msherry this is why you so frequently catch grammar mistakes in my HN comments and posts :-)