search

balanced / balanced-api

Balanced API specification.
221 stars 72 forks source link

Remove extra checks. #638

Closed steveklabnik closed 10 years ago

steveklabnik commented 10 years ago

@matin and I talked about it, and while we check for the correct status code and response schema on every test, this makes the tests more confusing then they have to be, as it's not the point of the test.

I'd like to hear what you all think of it, especially @matthewfl , who I feel will have a strong opinion.

matthewfl commented 10 years ago

I think it is fine to remove them from the features. It might be nice to have some default check, eg if the value is not explicitly checked for something then the POST should be expected to be a 201.

I think that this was left over mostly from the yaml scenarios which where checking the status code on basically every request for consistency.

steveklabnik commented 10 years ago

Yeah. We do do a basic 'is this JSON API' schema check on every request.

:shipit:

It's been fun, all. :heart: :joy: