balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

Dispute.created event doesn't include helpful info #649

Open rserna2010 opened 10 years ago

rserna2010 commented 10 years ago

However, dispute.updated contains more relevant info (eg the dispute id and transaction id).

Example dispute.created: { https://dashboard.balancedpayments.com/#/marketplaces/MP3QzuOB9IXSntkPK97f3y2P/events/EVed5bfedef30f11e3be9b06ae3bf089d4 If you replay something like this hits the webhook:

  "events": [
    {
      "links": {},
      "occurred_at": "2014-06-17T18:28:13.642000Z",
      "uri": "/events/EV247f3968f64d11e3b7bf06479e0ccc4c",
      "entity": {},
      "href": "/events/EV247f3968f64d11e3b7bf06479e0ccc4c",
      "type": "dispute.created",
      "id": "EV247f3968f64d11e3b7bf06479e0ccc4c"
    }
  ],
  "links": {}
}

Example dispute.updated: https://dashboard.balancedpayments.com/#/marketplaces/MP3QzuOB9IXSntkPK97f3y2P/events/EVed8fdec0f30f11e3be9b06ae3bf089d4

matthewfl commented 10 years ago

is this happening consistently, I think this might be a bug that is happening sporadically. We might also consider adding a link to the element directly on the events themselves.

dclausen commented 10 years ago

@matthewfl for us (LaunchTrack), the problem is happening consistently for both dispute.created and dispute.updated webhooks. We have 34 disputes ranging back to April 21 that have an empty entity hash.

Here are some event ids as examples:

EVa5299f24f70e11e3b84906ae3bf089d4 EVa40e6368f70e11e3a4d50292a1842d48 EVed5bfedef30f11e3be9b06ae3bf089d4 EVd64ac552f20311e3925e0292a1842d48 EV6f7f6706f0b411e39d8b02f32f1ac052

dclausen commented 10 years ago

any movement on this?

mjallday commented 10 years ago

We might also consider adding a link to the element directly on the events themselves.

I think the issue is that it's not rendering the dispute. If it did then you could use the href on the dispute to access it.