balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

v1.1 webhook returns empty 'entity' for account.created #666

Closed jonez734 closed 9 years ago

jonez734 commented 9 years ago

Using v1.1 of the api. I am getting an account.created event with an empty 'entity' (no data). 'account.updated' appears to be working as it should. I get an empty entity even when I set up a requestb.in, so this is not a problem with my code.

mjallday commented 9 years ago

@jonez734 can you please provide some more information such as the marketplace guid or the event guid for this request?

jonez734 commented 9 years ago

On Thu, Jul 24, 2014 at 11:02:13AM -0700, Marshall Jones wrote:

@jonez734 can you please provide some more information such as the marketplace guid or the event guid for this request?

/events/EV8adb280e11df11e497c7061e5f402045

/v1/marketplaces/TEST-MPuHeRqdMRlrHB2GMqN1t9Y

Please let me know if you need any more info.


Reply to this email directly or view it on GitHub: https://github.com/balanced/balanced-api/issues/666#issuecomment-50054708

mjallday commented 9 years ago

inside baseball I'm seeing a bunch of messages in the logs for customers being created but the entity not existing at render time. /inside baseball

looks like we're triggering the flush for the events too early, maybe a nested txn is firing the render hook... will keep digging.

/var/log/balanced/balanced-messages.log:2014-07-28 16:31:35,675 : WARNING : balanced_service.models.audits : 18484 : Thread-1293 : 1.2.93-1 : Entity CU4ZSqHh3HFo92dbnHlArMhP (account.created) not found.    
mjallday commented 9 years ago

oops, closed a little early. we're pushing a fix into our integration environment now to see if we have successfully resolved this issue.

mjallday commented 9 years ago

@jonez734 thanks for bringing this to our attention. we've released a fix into the integration environment and it appears to be working as expected. i've reproduced this and here's what the event now looks like

{
  "events": [
    {
      "links": {},
      "occurred_at": "2014-07-29T18:55:22.554000Z",
      "uri": "/events/EVe4ae0d2a175111e48d1e022e924b1919",
      "entity": {
        "customers": [
          {
            "name": "Bob McTavish",
            "links": {
              "source": null,
              "destination": null
            },
            "created_at": "2014-07-29T18:55:22.436152Z",
            "updated_at": "2014-07-29T18:55:22.554322Z",
            "dob_month": null,
            "phone": null,
            "href": "/customers/CU6XvJ2Jw6ovxcWO9mUhPbeh",
            "meta": {},
            "dob_year": null,
            "email": null,
            "address": {
              "city": null,
              "line2": null,
              "line1": null,
              "state": null,
              "postal_code": null,
              "country_code": null
            },
            "id": "CU6XvJ2Jw6ovxcWO9mUhPbeh",
            "business_name": null,
            "ssn_last4": null,
            "merchant_status": "no-match",
            "ein": null
          }
        ],
        "links": {
          "customers.source": "/resources/{customers.source}",
          "customers.card_holds": "/customers/{customers.id}/card_holds",
          "customers.bank_accounts": "/customers/{customers.id}/bank_accounts",
          "customers.debits": "/customers/{customers.id}/debits",
          "customers.destination": "/resources/{customers.destination}",
          "customers.external_accounts": "/customers/{customers.id}/external_accounts",
          "customers.cards": "/customers/{customers.id}/cards",
          "customers.disputes": "/customers/{customers.id}/disputes",
          "customers.transactions": "/customers/{customers.id}/transactions",
          "customers.refunds": "/customers/{customers.id}/refunds",
          "customers.reversals": "/customers/{customers.id}/reversals",
          "customers.orders": "/customers/{customers.id}/orders",
          "customers.credits": "/customers/{customers.id}/credits"
        }
      },
      "href": "/events/EVe4ae0d2a175111e48d1e022e924b1919",
      "type": "account.created",
      "id": "EVe4ae0d2a175111e48d1e022e924b1919"
    }
  ],
  "links": {}
}

we'll release this to the live environment shortly. this fix has been released.