search

balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

Bank Account Debits Always Return Pending States Unless They Fail #669

Closed cieplak closed 9 years ago

cieplak commented 9 years ago

This should fix this failing spec: image

mjallday commented 9 years ago

yes, this scenario uses a test bank account number that should transition transactions to pending. Fixes #668

mjallday commented 9 years ago

lgtm

mjallday commented 9 years ago

@matin if you look at the link I provided above, the scenario uses a bank account that's supposed to transition all txns created with it to the PENDING state.

Since I've been away I guess that what may have happened is that someone fixed the bug with test bank account numbers not transitioning correctly and this is what caused the scenario (which was incorrectly written but passed because of a bug) to fail.

If the scenario needs the bank account's transaction to be in the SUCCEEDED state then the fixture should use a different bank account number.

matin commented 9 years ago

Does that mean there was a bug in the scenario before?

mjallday commented 9 years ago

The way it was written depended on broken behavior. If you view that as a bug then yes :)

matin commented 9 years ago

Makes sense. It looks like the scenario was purely written to match the existing behavior of the API: https://github.com/balanced/balanced-api/commit/e86653505bbaf20aed808d58a1205d13ae3f8d74