search

balanced / balanced-api

Balanced API specification.
221 stars 72 forks source link

Order with holds not well defined #670

Closed matthewfl closed 10 years ago

matthewfl commented 10 years ago

Atm one has to set the order when creating a hold, however we do not define order as existing on the hold resource or the fact that one can set it when creating a hold. Additionally, when capturing a hold, trying to set an order then will cause a 500.

OHM24f45a0812aa11e4b88e02b12035401b https://botbot.me/freenode/balanced/2014-07-24/?msg=18533761&page=1

mjallday commented 10 years ago

@matthewfl i believe we fixed this earlier today - https://github.com/balanced/balanced/commit/47068244fc942fe4fc20ee8c906f25c7067fc5d6

does that resolve this issue?

matthewfl commented 10 years ago

@mjallday was that deployed within the last 15 minutes, otherwise I assume no

mjallday commented 10 years ago

What about https://github.com/balanced/balanced-docs/issues/423 ?

If you look at the commit I linked it links to a sentry task with the OHM24f45a0812aa11e4b88e02b12035401b. That looks the same as the OHM you specified above.