balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

Potential confusion of succeeded credits that haven't been settelled yet #717

Closed kyungmin closed 9 years ago

kyungmin commented 9 years ago

With the introduction of settlement, there could be potential confusions around the status of the credits associated with settlements. (i.e., users might think the credit was successfully made to the bank account, instead of the sweep account, by visually scanning the green succeeded status in the dashboard.)

This also could be a confusion point for API users. Should we change the credit status to something else (i.e., not settled? transferred?), and change it to succeeded when the settlement is made?

remear commented 9 years ago

Transaction statuses are standardized to pending, succeeded, failed. We should leave them alone. You don't settle credits. You settle an account balance.

I don't think there's any confusion here that couldn't be cleared up by the docs. The process will work more-or-less like this:

mjallday commented 9 years ago

+1 on @remear's interpretation. This is something that should be documented, the dashboard may expose the state of the settlement's credit if it needs to explain where the funds are.