balanced / balanced-api

Balanced API specification.
220 stars 72 forks source link

Expired disputes are still showing as "pending" #722

Open kyungmin opened 9 years ago

kyungmin commented 9 years ago

The API should update the status as "expired" when the respond_by date has passed.

https://dp.balancedpayments.com/#/marketplaces/TEST-MP7C7Ie18Da0FKtejkFB9xsC/disputes/DT4ysVRmeIb35q3GC90oWvYv

mjallday commented 9 years ago

@kyungmin i don't have enough information to do this currently.

the dashboard is the service that consumes these two bits of information and can tell you the display state of the dispute.

if you can provide more information about what an EXPIRED state means I can help you correctly model this.

msherry commented 9 years ago

I don't think 'expired' makes sense in this context. Disputes are either 'won', 'lost', or none of those yet, which would be 'pending'. They can go into arbitration after being won, which can either be a separate state or a movement from 'won' back to 'pending', but none of these is 'expired'.

kyungmin commented 9 years ago

I think @msherry is right. The dispute should automatically go to lost if the respond_by date has passed.

mjallday commented 9 years ago

@kyungmin the state of the dispute is not necessarily LOST until the bank tells us it is. The Balanced API does not have enough information to make this decision on its own. This is why I'm saying that the API should not be responsible for this, the dashboard should.

kyungmin commented 9 years ago

With the latest changes in the dashboard, we are now displaying disputes as "under review" if 1) the evidence is provided or 2) it has expired. We still want to be able to filter by "pending" vs. "under review". Do you still think API is not responsible for this?

screenshot 2014-12-18 14 18 23