search

balanced / balanced-dashboard

The Balanced dashboard.
https://dashboard.balancedpayments.com/
Other
2.28k stars 385 forks source link

New failed holds are shown as 'created' #1542

Closed msherry closed 9 years ago

msherry commented 9 years ago

The debit attempt on nov 15 failed with '301, Invalid account number', and the debit shows the proper failure code, but nothing about the hold indicates that it was never created successfully.

https://dp.balancedpayments.com/#/marketplaces/MP35BtXWqGuYEsv2RHH2CGtH/cards/CC7E1k7753ye78ujUKsIkP2v

image

(After seven days, this issue becomes https://github.com/balanced/balanced-dashboard/issues/1541)

kyungmin commented 9 years ago

Looks like it's an API issue.

{
  "card_holds": [
    {
      "status": "succeeded",
      ...
    }
}

Currently, the dashboard displays succeeded holds as expired if it has passed the expiration date or voided if it has passed the voided at date.

@mjallday any thoughts?

mjallday commented 9 years ago

did the hold fail or the capture failed?

msherry commented 9 years ago

The debit failed. No hold was explicitly created -- these were straight debit attempts.

mjallday commented 9 years ago

Can I get the GUID of the debit in question? I'm not sure how the hold could succeed but the debit fails unless the hold expired.

msherry commented 9 years ago

Any of the debits on the card linked above will do, I believe.

mjallday commented 9 years ago

OK, Looked at /card_holds/HL2ZkACXYTSIDZVQ10tBVrp8. It failed at the processor level due to "Invalid Account Number". balanced is using only the presence of the processor href as the indicator of state. Here's an issue to track this internally, it doesn't look like we bubble up enough information to work around this in the dashboard currently.

kyungmin commented 9 years ago

closed by https://github.com/balanced/balanced/issues/700