search

balanced / balanced-dashboard

The Balanced dashboard.
https://dashboard.balancedpayments.com/
Other
2.28k stars 386 forks source link

Logging a better mixpanel event when transitioning routes #1550

Closed cohitre closed 10 years ago

mjallday commented 10 years ago

@cohitre can you please either make sure google analytics gets the same love or we make sure we follow that up at some point? I use https://www.google.com/analytics/web/?hl=en#report/visitors-overview/a30733850w57315546p68358200/ to view visitors to all our sites. It all looks like it's still working but would like to make sure it's optimal if possible. :)

mahmoudimus commented 10 years ago

@mjallday @cohitre does it make sense to use segment.io?

mjallday commented 10 years ago

i'm not familiar with it so i'm not sure how much benefit it's going to give over having a straight ga and mixpanel integration.

if we need to add another integration then i think it should be considered. afaik in the past we've had a single library which knows how to talk to both ga and mixpanel and it has been very simple and works well. that's what concerns me when i start to see code like in this pull-request for a specific analytics package rather than using the library that we built.

@cohitre sorry i wasn't clear about my concern. what i should have said was that these calls should have used the analytics library. and they are so i have no concerns here :) this looks great.

cohitre commented 10 years ago

The AnalyticsLogger#trackEvent logs in both mixpanel and GA