search

balanced / balanced-dashboard

The Balanced dashboard.
https://dashboard.balancedpayments.com/
Other
2.28k stars 385 forks source link

Bank account removal reasons not displayed anymore #1619

Open msherry opened 9 years ago

msherry commented 9 years ago

Bank accounts removed due to NOC (Notice of Change) used to display the reason for removal under the 'Status' area -- they are now just saying 'Removed' with no reason.

https://dp.balancedpayments.com/#/marketplaces/MP469NHQYWQNCmIcHmoS1KP5/bank_accounts/BA66MkTzMyCF5cfyUQt9dN2y is one example.

image

image

kyungmin commented 9 years ago

I don't think bank accounts used to display the reason for removal previously. Is the balanced.noc_reason field in meta generated by Balanced? If so, is meta the right place to add the removal reason? I don't see this message in anywhere else in this bank account.

msherry commented 9 years ago

I could have sworn that I remembered seeing this, but you're probably right. In that case, this is now a feature request, not a bug :)

And yes, meta['balanced.noc_reason'] comes directly from Balanced.

kyungmin commented 9 years ago

Why are we using meta for communicating this instead of adding a field like noc_reason? Anyone can edit/remove the meta fields.

msherry commented 9 years ago

That's probably why it was never in the dashboard and I'm wrong. Credit failures have a specialized field for this (failure_reason) (which information happens to be duplicated in meta), but we probably just dumped the NOC reason in meta as a quick hack and never added the same field that transactions have.