balanced / balanced-dashboard

The Balanced dashboard.
https://dashboard.balancedpayments.com/
Other
2.28k stars 386 forks source link

Deleted Bank Accounts Still Appear in the Dashboard #405

Open andrewnossiter opened 11 years ago

andrewnossiter commented 11 years ago

When a user deletes a bank account, it still shows up in their dashboard. Can we please make it so that a bank account is completely deleted (visually) form the dashboard!

mahmoudimus commented 11 years ago

There is no such thing as "DELETED" bank account, a bank account is unstored. Ideally, you want to show the unstored blob which allows searching by the bank account's fingerprint.

nodesocket commented 11 years ago

Also, if you try and view a deleted bank account from the search, get:

assertion failed: Cannot call get with 'id' on an undefined object. 

Should we really display deleted bank accounts in the search?

mjallday commented 11 years ago

I agree with @nodesocket - Deleted bank accounts are not supposed to be addressable so they shouldn't come back in search results. Transactions that used that bank account, they should come back but not the ba itself.

mjallday commented 11 years ago

This is still a bug and still causing customer support issues.

jondkinney commented 10 years ago

:+1: this bugs me on a daily basis as I'm keeping a close eye on our new but growing marketplace and customers/funding instruments. Several test bank accounts and/or accounts we've delete for customers remain in the list and clutter things considerably.

kyungmin commented 10 years ago

@mjallday Deleted bank accounts are still showing up in search results. Can this be fixed in balanced-api?

msherry commented 10 years ago

Is this different than showing the invalidated cards/bank accounts as 'Removed' in the dashboard? Are we getting rid of that?

kyungmin commented 10 years ago

Adding "Removed" state help clarify confusions, but we probably should not display deleted payment methods in the search results regardless. Or do you think it's necessary to display them for debugging purposes? Any thoughts?

msherry commented 10 years ago

As long as they're still shown attached to the customer or transaction in question, I don't think we need them in search results. Thanks for clarifying, @kyungmin.