balanced / balanced-python

Balanced API library in python.
MIT License
69 stars 49 forks source link

Python3 support #106

Closed zmike808 closed 1 year ago

zmike808 commented 10 years ago

Implemented python3 support (HOWEVER: at the cost of python2 support). Currently, requires wac to be installed from my fork, since I had to port that to python3 as well. However, I will be submitting a pull request to wac's author as well. Passed all test cases of nosetests.

msherry commented 10 years ago

To be clear, are you saying this will no longer work with python 2? That might be a nonstarter, if so.

mjallday commented 10 years ago

holy shit, this is epic!. most of the changes look pretty minor so i'm sure we could work on the compatbility thing.

zmike808 commented 10 years ago

@msherry yes, but as @mjallday said I'm sure it'd be fairly simple to add dual compatibility. However, i just needed python3 support for a project I'm currently working on so I didn't bother worrying about backwards compatibility. Wac would also need to be modified to be backwards compatibility, since I had to fork wac and port it to python3 as well.

If I have the time I will try to add backwards compatibility, although if anyone wants to go ahead and do that by all means go ahead. However, for now this should suffice as an alternative for anyone looking to use balance with only python3.

mjallday commented 10 years ago

WAC pull-request https://github.com/bninja/wac/pull/15

@zmike808 can you also edit the travis file and stick python3 in there?

https://github.com/balanced/balanced-python/blob/master/.travis.yml#L4

I like where this is going and the changes here and in the wac pr do not look that difficult to port back so I'll figure out how we can work with this.

mahmoudimus commented 10 years ago

We can use: https://pypi.python.org/pypi/six or http://python-future.org/ to maintain backward compat.

mjallday commented 10 years ago

First step in moving forward with this would be to get the wac pull-request published.

We'll need to tweak that to be backwards compatible with python >= 2.6