search

balanced / balanced-ruby

Balanced API library in ruby.
MIT License
111 stars 47 forks source link

delete -> unstore #142

Closed steveklabnik closed 10 years ago

steveklabnik commented 10 years ago

We want to move to using 'unstore' as the preferred name for this action.

Keeping delete around since it's basically zero maintenance burden. No reason to force people to re-write code they've already written.

remear commented 10 years ago

What do we want to do about https://github.com/balanced/balanced-ruby/blob/1.1.0/lib/balanced/resources/resource.rb#L129-L135 and the tests that look to be using them?

steveklabnik commented 10 years ago

My grep skills are terrible. Let me investigate.

mahmoudimus commented 10 years ago

This seems like an anti-pattern, we should probably refactor this to a mixin -- we're not following DRY here

steveklabnik commented 10 years ago

I am not totally opposed to a mixin, but this is a very tiny diff. Is it really worth replacing with a bunch of metaprogramming? My initial say is no, but maybe it is.

mahmoudimus commented 10 years ago

@steveklabnik sure makes sense, just really worried about you going through the code and modifying all of these branches, seems like a code smell that I might've introduced

steveklabnik commented 10 years ago

Cool. Let's not worry about this until the complexity justifies it.