search

balanced / balanced-ruby

Balanced API library in ruby.
MIT License
111 stars 47 forks source link

implemented the customer resource #79 #82

Closed rloomba closed 11 years ago

rloomba commented 11 years ago

No it doesn't work, I'll fix this.

rloomba commented 11 years ago

The Transaction spec is still failing. Transaction is implemented through search, and it seems to have a 1- 2 second delay. Some possible solutions:

  1. adding in a short delay
  2. remove the spec altogether
  3. instead of counting the transactions, I could sum all the different credits and debits?
mjallday commented 11 years ago

I believe the issue here is that we ingest into ES in the background and the transactions endpoint uses ES to gather its results so until the index is updated they aren't returned.

Transaction is an undocumented endpoint I believe so there's probably no problem with either adding the delay or removing the spec completely. Summing credits and debits is missing the point of the transactions endpoint.

mjallday commented 11 years ago

@rloomba if you can fix that on_behalf_of comment from @mahmoudimus i'll merge this in for you

mahmoudimus commented 11 years ago

and my 80character limit homie.

rloomba commented 11 years ago

@mjallday I believe the on_behalf_of issue was fixed in 14ffd0440dfb113807ddd3eece3b9a8d9472227b. Did you just want me to add in a on_behalf_of_uri attribute?

@mahmoudimus your 80 char was fixed in ac8a942a439b6c8bcadcd18bd6c3501f7a6de8e1

rloomba commented 11 years ago

Ah ok, I get it. I'll fix it.

mjallday commented 11 years ago

good work @rloomba! :)