balancednetwork / balanced-java-contracts

Java contracts for Balanced
Apache License 2.0
10 stars 15 forks source link

feat: Feature/crosschain lp #456

Open TRSSMG opened 1 month ago

TRSSMG commented 1 month ago

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 78.20513% with 51 lines in your changes missing coverage. Please review.

Project coverage is 73.12%. Comparing base (fe8a9b9) to head (1f487ca). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...nced/score/core/dex/IRC31StandardSpokeLpToken.java 63.79% 14 Missing and 7 partials :warning:
.../balanced/score/lib/utils/AddressBranchDictDB.java 0.00% 10 Missing :warning:
...twork/balanced/score/core/rewards/RewardsImpl.java 80.76% 2 Missing and 3 partials :warning:
.../score/lib/utils/BranchedNetworkAddressDictDB.java 0.00% 5 Missing :warning:
...twork/balanced/score/core/daofund/DAOfundImpl.java 0.00% 2 Missing :warning:
.../java/network/balanced/score/core/dex/DexImpl.java 96.77% 1 Missing and 1 partial :warning:
...ork/balanced/score/core/stakedlp/StakedLPImpl.java 94.11% 2 Missing :warning:
...balanced/score/lib/utils/NetworkAddressDictDB.java 0.00% 1 Missing and 1 partial :warning:
...rk/balanced/score/core/rewards/DataSourceImpl.java 66.66% 1 Missing :warning:
...etwork/balanced/score/lib/utils/TokenTransfer.java 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #456 +/- ## ============================================ + Coverage 73.06% 73.12% +0.06% - Complexity 1603 1617 +14 ============================================ Files 116 120 +4 Lines 7685 7744 +59 Branches 936 935 -1 ============================================ + Hits 5615 5663 +48 - Misses 1666 1674 +8 - Partials 404 407 +3 ``` | [Flag](https://app.codecov.io/gh/balancednetwork/balanced-java-contracts/pull/456/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=balancednetwork) | Coverage Δ | | |---|---|---| | [java](https://app.codecov.io/gh/balancednetwork/balanced-java-contracts/pull/456/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=balancednetwork) | `73.12% <78.20%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=balancednetwork#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

AntonAndell commented 1 month ago

What do you think creating a library like XCallLib but for token transfers? So that you can just call that in any contract. Which will query the daofund for the fee, check if token is in assetManager else use xTransfer.