search

balancednetwork / balanced-network-info

ℹ️ Balanced network analytics.
https://stats.balanced.network
MIT License
0 stars 0 forks source link

Update performance details calculation #205

Closed hetfly closed 6 months ago

hetfly commented 7 months ago

colse #181

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
balanced-network-info ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 2:25pm
hetfly commented 7 months ago

also added 6 month period

hetfly commented 6 months ago

@parrot9design

Is it possible to add the amount of ICX bought & burned to the top-level value?

It is, but I'm not sure if we want to do that.

We could either check the contracts, see how many ICX have actually been burnt, but that happens only once every few days, so the daily and sometimes weekly overviews would show 0 ICX burnt, with the detailed breakdown below showing non zero values.

We could also take the $ value over the shown period and divide it by the current ICX price. That would give us non zero values every time, however, over the larger time frames it could show significant discrepancy, compared to the burn numbers from the bar chart.

I'd probably reconsider putting the previous label in, ICX Burn Fund, and show only the overall $ values.

the network fees only seem to be ~15% of what's earned? I thought they were set to 25%?

Yeah, it's not much now, but I think it's correct. Half of the fees goes to the Foundation, 30% goes to the bBALN holders from the other half.

parrot9design commented 6 months ago

I'd probably reconsider putting the previous label in, ICX Burn Fund, and show only the overall $ values.

Dammit @hetfly, I was trying to go for consistency with the ICX burned label between pages. 😂

In all seriousness though, that would be the best option. We track the ICX amount elsewhere so it's not as important to include here.

Let's use Economic enshrinement for the label, though, and include the enshrinement tooltip to provide more context. Screenshot 2024-04-16 at 4 12 38 PM

Yeah, it's not much now, but I think it's correct. Half of the fees goes to the Foundation, 30% goes to the bBALN holders from the other half.

It's 30% overall, not 30% of the remaining 50% though, right? So 50 / 30 / 20 (burn / bBALN holders / DAO Fund)?

If I'm wrong and it's 30% of the remaining 50%, damn, fees are lower than I thought. The Rewards section in the app assumes the network fees are double the current amount, so that would be a high priority to fix.

hetfly commented 6 months ago

It's 15% overall, numbers pulled from the contract are 30% for the bBALN holders and 70% for the DAO. 50% goes automatically towards the burn. That 30/70% ratio is applied after the cut.

Good catch with the estimate in the app, thanks! It will be updated with this PR https://github.com/balancednetwork/balanced-network-interface/pull/1319