search

balancednetwork / balanced-network-info

ℹ️ Balanced network analytics.
https://stats.balanced.network
MIT License
0 stars 0 forks source link

fix: update texts, order tokens in TokenSection.tsx, add plural strin… #23

Closed hetfly closed 3 years ago

hetfly commented 3 years ago

…g ending for tokens and dollars

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/balanced-dao/balanced-network-info/5FThiLoTv2SyLmybPZfyK7xG9NYq
✅ Preview: https://balanced-network-info-git-fix-touch-up-a-fe-0a3c48-balanced-dao.vercel.app

hetfly commented 3 years ago

Regarding the change from Balance Token -> Balance Tokens and Balanced Dollar -> Balanced Dollars Since the names are queried from geometry backend I hardcoded the "s" ending for names ending with token or dollar to avoid more complex solutions. I don't like this very much, but couldn't think of anything else. Is it ok @hieunguyenebox ?

edit: https://github.com/balancednetwork/balanced-network-info/pull/23/files#diff-4b321d87e2a9c2724279905843d2ddfd273542f73f95cc838dc06ea77d92288cR228

octocat512 commented 3 years ago

@parrot9design I think the section is for the token name that is used on the smart contract side. Why we use plural nouns for the name of the token.

image

parrot9design commented 3 years ago

@WeiLi512 For the marketing site and docs, we always use the plural form as it sounds better. To be honest, it's not a huge deal either way, so if it does make the code ugly because you have to hardcode the s in, we can just leave it as is.

octocat512 commented 3 years ago

@hetfly I think you can remove the hardcoded code. Please check the above comment.

hetfly commented 3 years ago

hardcoded 's' removed @WeiLi512