search

balancednetwork / balanced-network-info

ℹ️ Balanced network analytics.
https://stats.balanced.network
MIT License
0 stars 0 forks source link

feat: init token routing #24

Closed hetfly closed 2 years ago

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/balanced-dao/balanced-network-info/DPpDCUCMexvoqQTmbxjUzNokuSU4
✅ Preview: https://balanced-network-info-git-feat-add-coin-wiki-pages-balanced-dao.vercel.app

hetfly commented 3 years ago

@WeiLi512 1) token.totalSupply from useAllTokensQuery() shows circulating supply instead of total supply, at least for ICX 2) I need to get info about tokens 24h volume, can you point me to some docs where I can find out how ? thanks

hetfly commented 3 years ago

@parrot9design @WeiLi512 please review, we are missing ICX total supply and 24h volume for all tokens, I assume total supply is the same as circulating supply for BALN, sICX a bnUSD. Do we ship as is or do we wait ?

hetfly commented 3 years ago

@parrot9design do you see the links without arrows here as well ? If so, please specify your browser version https://balanced-network-info-i07pt108g-balanced-dao.vercel.app/

hetfly commented 3 years ago

Updated based on the feedback, but the current staking rewards value in collateral section is a static one. I didn't find a way to get it dynamically.

parrot9design commented 3 years ago

@parrot9design do you see the links without arrows here as well ? If so, please specify your browser version

I see the arrows now. They make the token names harder to read at smaller screen sizes, though – can we increase the width of the asset column to avoid splitting words in half?

Current Preferred
Screen Shot 2021-07-23 at 4 12 15 PM Screen Shot 2021-07-23 at 4 13 47 PM

the current staking rewards value in collateral section is a static one. I didn't find a way to get it dynamically.

That I wasn't aware of, thanks for bringing it to my attention! It looks like you've found a way to get it dynamically now? Where are you pulling the data from?

hetfly commented 3 years ago

Token name width is fixed, staking rewards are still static, I just updated the current value.

parrot9design commented 3 years ago

This is great, thanks @hetfly. I've opened an issue to get the ICX staking apy resolved: https://github.com/balancednetwork/balanced-network-info/issues/29

Ideally I would like to get that implemented before we publish this, to minimise the number of static data points we need to maintain.

parrot9design commented 3 years ago

@hetfly it looks like we have a dynamic APY for ICX staking now: https://github.com/balancednetwork/balanced-network-info/pull/34

hetfly commented 3 years ago

@parrot9design @WeiLi512 please review

BennyOptions commented 2 years ago

Not going to work on this for now