search

balancednetwork / balanced-network-info

ℹ️ Balanced network analytics.
https://stats.balanced.network
MIT License
0 stars 0 forks source link

Decimal Place Logic #73

Closed BennyOptions closed 2 years ago

BennyOptions commented 2 years ago

We need to decide how to handle tokens that have a price below 1 cent, as it appears as 0 currently. We should come up with a standard decimal-place logic.

gedanziger commented 2 years ago

I think we should just do what crypto exchanges do for price precision vs trading price (although with less resolution). Tried and true is probably the way to go

BennyOptions commented 2 years ago

Yeah sounds good to me - what is the standard logic?

parrot9design commented 2 years ago

Can we just use 4 decimal places for every token? We use the same format on the Trade page, it makes sense to keep it consistent.

BennyOptions commented 2 years ago

What about when we have assets that have values in the hundreds or thousands? I don't think I've seen BTC quotes on exchanges with 4 decimal points as an example

For example:

parrot9design commented 2 years ago

Hmm, good point. What do you think about this logic?

If $10 or above: 2 decimals If below $10: 4 decimals If below $0.01: 6 decimals

BennyOptions commented 2 years ago

Yeah I'm ok with that. @octocat512 please implement it with the above logic