balancednetwork / balanced-network-info

ℹ️ Balanced network analytics.
https://stats.balanced.network
MIT License
0 stars 0 forks source link

feat: 🎸 header and footer #8

Closed ghost closed 3 years ago

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/balanced-dao/balanced-network-info/6cSF8YxRCdA1FvsFzsmyn5vWiQBn
✅ Preview: https://balanced-network-info-git-feature-header-an-e9e0aa-balanced-dao.vercel.app

ghost commented 3 years ago

@WeiLi512 plz review

ghost commented 3 years ago

@WeiLi512 plz check again

parrot9design commented 3 years ago

The logo and navigation sizing looks much better. 👍

The overview and governance sections still need a few adjustments:

Current Design
Screen Shot 2021-06-24 at 3 00 37 PM Screen Shot 2021-06-22 at 8 14 07 PM

(I crossed out the first two points as Pete isn't convinced his original design is better than what's there currently.)

Footer

Current Design
Screen Shot 2021-06-24 at 3 00 44 PM Screen Shot 2021-06-24 at 3 00 51 PM
parrot9design commented 3 years ago

To recap:

  1. The transparency of the TVL icon needs fixed (I believe it’s isolated to this PR)
  2. The overview and governance stats need the bold style removed
  3. We need to add Stats to the navigation:

Top of page 3F5AB1C8-C3B2-4717-BC87-763CBEC8DEDC

Bottom of page A394CD3F-2002-48CB-93A1-108E79E55778

@WeiLi512 @hieunguyenebox Let’s make sure this PR makes it into tomorrow’s release.

ghost commented 3 years ago

@parrot9design all fixed, please check

parrot9design commented 3 years ago

Looks good! Just need to make the underline active for the stats link so people know it's the active page.

Example:

Screen Shot 2021-06-27 at 9 01 29 AM Screen Shot 2021-06-27 at 9 01 26 AM