search

balancednetwork / balanced-network-info

ℹ️ Balanced network analytics.
https://stats.balanced.network
MIT License
0 stars 0 forks source link

feat: init sorting #95

Closed hetfly closed 2 years ago

hetfly commented 2 years ago

close #92

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/balanced-dao/balanced-network-info/DZ4QAPmQaD7kPQu3SKbFsLDgLybK
✅ Preview: https://balanced-network-info-git-feat-add-ability-fba79f-balanced-dao.vercel.app

parrot9design commented 2 years ago

It looks like the token price is ordered by the 24 hour % change. Let's order it by $ value instead.

Screen Shot 2022-02-18 at 1 34 48 PM

Otherwise, this looks all good. The animation could start to feel a little too slow/over the top for people who are chronic re-sorters, but let's see how it goes. We can always cut it back if it starts to get annoying.

hetfly commented 2 years ago

@parrot9design Isn't it better to keep price sorting based on 24h change? Seems to me as relatively more important info to sort by. If you want to sort by token value, marketcap is better metric for that anyway.

parrot9design commented 2 years ago

@parrot9design Isn't it better to keep price sorting based on 24h change? Seems to me as relatively more important info to sort by. If you want to sort by token value, marketcap is better metric for that anyway.

I guess it depends. Sorting based on 24h change is good for spotting trends, but sorting by $ value makes it easier to compare prices, particularly of stablecoins. As for which is better...is there any way we could have the option to sort by both?

hetfly commented 2 years ago

I guess it depends. Sorting based on 24h change is good for spotting trends, but sorting by $ value makes it easier to compare prices, particularly of stablecoins. As for which is better...is there any way we could have the option to sort by both?

I couldn't think of anything not too much invasive for the UI. Changed sorting based on price, we can revisit this later maybe with some feedback from the community

parrot9design commented 2 years ago

I guess it depends. Sorting based on 24h change is good for spotting trends, but sorting by $ value makes it easier to compare prices, particularly of stablecoins. As for which is better...is there any way we could have the option to sort by both?

I couldn't think of anything not too much invasive for the UI. Changed sorting based on price, we can revisit this later maybe with some feedback from the community

Sounds great, thanks @hetfly!

jac0x commented 2 years ago

Looks absolutely stunning! Thanks for your great work @hetfly @octocat512 LGTM