search

balancednetwork / balanced-network-interface

An open-source interface for the Balanced Network protocol (https://balanced.network)
https://app.balanced.network/
22 stars 21 forks source link

Notification not accurate to reality #1221

Open BennyOptions opened 1 year ago

BennyOptions commented 1 year ago

See the screenshot and relevant transaction. The transaction was for 32,862 ICX, but notification says 33k. Need the notification to pull data from the blockchain, not from the FE expectations. This is the result of the sandwich attacker fyi.

Screenshot 2023-07-19 at 3.20.01 PM.png

FezBox commented 1 month ago

@hetfly is this still a valid bug?

hetfly commented 1 month ago

Yes, but it requires considerable effort. Notifications are populated based on the estimates prior to the transaction execution. This would require fetching transaction logs after the execution and updating the notification based on that, so refactoring whole notification system, as well.