fix: show lp fees APR in user liguity detail (#1201)

balancednetwork / balanced-network-interface

An open-source interface for the Balanced Network protocol (https://balanced.network)

https://app.balanced.network/

22 stars 22 forks source link

Closed weeddotv closed 4 months ago

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
balanced-network-interface	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 1, 2024 3:34am

hetfly commented 4 months ago

Found two issues, otherwise looks good, thanks

[ ] In the LP description section, there should still be an APR range.
[ ] In the responsive layout, when the total APR is merged into a single number, you have to add the fees APR after multiplying the base by the boost, not before, otherwise wrong APR is shown.

hetfly commented 4 months ago

APR on phone is correct now, thanks!

[ ] The range shows wrong numbers, same issue as previously. You have to add the fees APR after applying the boost.

sICX/bnUSD pair for example, the range should show 1.39% - 1.95%