search

balancednetwork / balanced-network-interface

An open-source interface for the Balanced Network protocol (https://balanced.network)
https://app.balanced.network/
22 stars 22 forks source link

Feature/stabilify funds route #1353

Closed swiftcc624 closed 2 months ago

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
balanced-network-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 1:45am
parrot9design commented 3 months ago

Swaps are pretty smooth, excited to release this. 🔥 Just a couple minor things.

The content should fit on one line, or if it's too long, wrap to two lines the way it currently does on the Bridge tab:

Current Preferred
Screenshot 2024-07-05 at 12 28 01 PM Screenshot 2024-07-05 at 12 28 44 PM

This happens in the live app as well, but is there a way to prevent high slippage for small trades? Compare the price impact for 1 USDC versus 10 (also 1, 10, 100 bnUSD):

parrot9design commented 2 months ago

Managed to find a bug that triggers a white screen every time:

https://github.com/balancednetwork/balanced-network-interface/assets/63842577/9071aebc-5c9d-4c80-93e0-0c298aa7f35e

To reproduce the issue, set USDC as the receiving token and type or paste in a value of at least 6 digits. The page will then white screen. Refresh the page, then try to type into the USDC field again. This time, a single digit should be enough to trigger the white screen. You can get it out of this cycle by entering numbers into the other asset field or changing up the assets, but you can always get back to the white screen by repeating the initial steps.

Before we merge this PR, can we remove IUSDC, IUSDT, and USDS from the token list (maybe even FIN while we're at it)? These stablecoins have no value and could be mistaken for those that do, so it would be nice to get rid of them before we see an influx of USDC & USDT from other chains.