balancednetwork / balanced-network-interface

An open-source interface for the Balanced Network protocol (https://balanced.network)
https://app.balanced.network/
22 stars 22 forks source link

feat: add base chain #1355

Closed 0xmilktea closed 3 months ago

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
balanced-network-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 5:27am
FezBox commented 3 months ago

@0xmilktea I tried to transfer eth from arbi to icon (or base) clicked transfer its asks me to authorize after I click it then nothing happens image

parrot9design commented 3 months ago

When I try to transfer USDC from ICON to Base, I get this message in Hana and can't move past it:

Screenshot 2024-06-25 at 4 31 07 PM

If I then try to test a USDC transfer to another chain (probably other transactions as well), Base messaging appeared in the modal during the transfer process: Screenshot 2024-06-25 at 4 32 11 PM

And the transaction still shows as pending in the UI, even though the transaction is marked as approved on xCallScan. Screenshot 2024-06-25 at 4 40 50 PM

I suspect this behaviour is due to an issue in how transactions are handled when the wallet flags an issue. It's definitely a problem on mainnet as well so it doesn't need to be resolved in this PR, but it is reproducible, so it will help us address the residual UI issues around cross-chain transaction activity.

parrot9design commented 3 months ago

I'm unable to transfer USDC to Base on any chain. From ICON, the wallet stops it. From Arbitrum & Avalanche, the transaction rolls back halfway through. @FezBox this looks to be a smart contract issue.

Screenshot 2024-06-25 at 5 29 09 PM

EDIT: The revert state is a known issue because we have no USDC deposits on Base yet. We can handle for that the same way that's been suggested for the Stability Fund swaps:

327601960-d37e8dbe-8880-48ae-9c50-fc01c38868da

When you enter an amount larger than can be sent to the chosen blockchain, make the Transfer button inactive and include this message underneath:

Only [{amount} {ticker}]() is available on {blockchain}.

When there's nothing available:

0 {ticker} is available on {blockchain}.

parrot9design commented 3 months ago
parrot9design commented 3 months ago

If you choose to swap 100% of your ETH from Base, the frontend doesn't account for the gas fee so the Swap button in the confirmation modal won't trigger the wallet.

The gas fee is also ignored on the Bridge tab, where you can choose to send 100% of your ETH from Base and Arbitrum, and AVAX from Avalanche.

parrot9design commented 3 months ago

Screenshot 2024-06-27 at 4 35 12 PM


Screenshot 2024-06-27 at 4 32 59 PM

parrot9design commented 3 months ago

When you try to transfer from an EVM chain that isn't the active one, typing in an amount greater than the wallet balance won't trigger the Insufficient {ticker} message. You can open the confirmation modal and switch networks, but then nothing happens when you click Transfer.