Update the wallet dropdown and asset lists

balancednetwork / balanced-network-interface

An open-source interface for the Balanced Network protocol (https://balanced.network)

https://app.balanced.network/

23 stars 22 forks source link

Update the wallet dropdown and asset lists #1444

Closed hetfly closed 2 months ago

hetfly commented 2 months ago

close #1403

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
balanced-network-interface	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 12, 2024 8:19am
balanced-network-stats	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 12, 2024 8:19am

hetfly commented 2 months ago

@parrot9design Ad the scrollbar styles - I think that all the scrollbars are behaving the same. The nicer style is active when you stay focused in the dropdown. When you move the focus out of it, it activates the ugly styles. Is this the case for you too?

All the scrollbars in the app are native, no styles are applied, if possible I'd like to keep it that way 😅

VIdeo here https://streamable.com/skfgqr

parrot9design commented 2 months ago

Your video is no longer available, but here's the difference I see with the scrollbar between the sign-in modal and the others: https://github.com/user-attachments/assets/644ce5e9-2da1-45fe-8e8a-162db2485e1a

Note that I have my OS set to only display scroll bars when scrolling. When set to always show the scroll bar, it's the same white style everywhere. Is it quite difficult to customise the style, even moderately? It looks awful whenever someone posts a screenshot with the scroll bar in view, would be nice to harmonise it with the UI. 😅

[x] Can we keep the wallet modal open in the background when you click an ICON-based asset?

[x] Let's update the wallet search placeholder text to Search assets and blockchains

Screenshot 2024-09-11 at 2 46 07 PM

[x] Let's also add an ellipsis to the end of each placeholder message, as we haven't used them consistently.
[x] And let's remove for from this message:

hetfly commented 2 months ago

Is it quite difficult to customise the style, even moderately?

It was my PTSD from the days when handling scrollbars basically meant using javascript, which usually affected the scrolling experience itself (hardly in a good way) and looked differently in each browser anyway 😅 But now it looks like the support in modern browsers is quite decent, so it looks like we might have a good solution. Let me know how this feels @parrot9design 👍

parrot9design commented 2 months ago

Legend! That looks so much better, appreciate you looking into this again. Let's update the scrollbar colour to rgb(20, 74, 104), then it should be good to ship. 💪