balancednetwork / balanced-network-interface

An open-source interface for the Balanced Network protocol (https://balanced.network)
https://app.balanced.network/
23 stars 22 forks source link

Feat/add sui tokens #1527

Closed swiftcc624 closed 1 week ago

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
balanced-network-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:24am
balanced-network-stats ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:24am
hswap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:24am
parrot9design commented 1 week ago
swiftcc624 commented 1 week ago

@parrot9design I fixed the formatting of symbols - afSUI and it will be default to Sui.

When I try to deposit haSUI or vSUI collateral, I get a Failed signing error in Hana wallet and can't go any further. This probably also happens with afSUI, but I ran into an error trying to get some so I haven't been able to test it yet.

I think it's related to Hana Wallet.

parrot9design commented 1 week ago

The formatting is fixed in the collateral dropdown, but it's still all-caps everywhere else:

Screenshot 2024-11-13 at 6 45 40 PM

When I try to deposit haSUI or vSUI collateral, I get a Failed signing error in Hana wallet and can't go any further. This probably also happens with afSUI, but I ran into an error trying to get some so I haven't been able to test it yet.

I think it's related to Hana Wallet.

I set up Suiet to verify, but it's actually a problem there too. What wallet were you testing with that allowed it to work?

Here was the message it provided:

Dry run failed, could not automatically determine a budget: MoveAbort(MoveLocation { module: ModuleId { address: a3c66ac08bca78a475954683a872a296fd61a28d478c4a8ebce676fc38f502d6, name: Identifier("asset_manager") }, function: 27, instruction: 8, function_name: Some("enforce_version") }, 8) in command 2 (code: -1)

swiftcc624 commented 1 week ago

I am using Sui wallet, https://chromewebstore.google.com/detail/sui-wallet/opcgpfmipidbgpenhmajoajpbobppdil

swiftcc624 commented 1 week ago

@parrot9design I fixed formatting symbol

swiftcc624 commented 1 week ago

@parrot9design I fix the issue with Hana Wallet, it should work now.

parrot9design commented 1 week ago

Works well now, thanks! Just need to adjust the style in the modals: Screenshot 2024-11-14 at 10 36 00 AMScreenshot 2024-11-14 at 10 42 05 AM

Screenshot 2024-11-14 at 10 45 40 AM
swiftcc624 commented 1 week ago

@parrot9design I fixed formatting symbol

parrot9design commented 1 week ago
Screenshot 2024-11-14 at 4 00 49 PM
swiftcc624 commented 1 week ago

@parrot9design sorry, i fixed it as well

parrot9design commented 1 week ago

Thanks @swiftcc624.

I noticed that they show as empty in the All collateral section, even after I've opened a position:

Screenshot 2024-11-14 at 4 53 01 PM Screenshot 2024-11-14 at 4 53 28 PM

Screenshot 2024-11-14 at 5 04 53 PMScreenshot 2024-11-14 at 5 04 47 PM

Once we get that fixed, it should be good to merge.

EDIT: the All collateral section updated literally right after I published this comment. The loan value is getting pulled through, but it appears to have trouble with the collateral:

Screenshot 2024-11-14 at 5 06 50 PM
swiftcc624 commented 1 week ago

@parrot9design I fixed the value in All collateral tab.