search

balancednetwork / balanced-network-interface

An open-source interface for the Balanced Network protocol (https://balanced.network)
https://app.balanced.network/
23 stars 22 forks source link

Implement wICX #1536

Open hetfly opened 6 days ago

hetfly commented 6 days ago

close #1534

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
balanced-network-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 4:46pm
balanced-network-stats ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 4:46pm
hswap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 4:46pm
hetfly commented 5 days ago

@FezBox managed to temporarily put in a check for a better trade using the queue while there is still liquidity. We will have to do a clean up after the queue is emptied and deprecated anyway, there is lot's of conditional code using the queue.

Can we get some liquidity in the new pool so that we can properly test the routing and trade picking? (queue vs wICX)

@parrot9design only when supplying and trading into ICX, wICX contract is used, but it's all abstracted from the user and ICX symbol is displayed instead of wICX. While we have the queue working in parallel temporarily, do we want to differentiate the wICX contract somehow? At least in Your pools section, we could show wICX/sICX as the pool name? If the user had both, the queue and wICX/sICX in that section, it could look a bit confusing.

parrot9design commented 4 days ago

Let's use ICX / sICX to identify the new pool so we can omit all mention of wICX from the UI.

We can call the old one the ICX queue:

Screenshot 2024-11-22 at 1 05 10 PM
parrot9design commented 1 day ago

There are still a few mentions of wICX in the UI: Screenshot 2024-11-25 at 10 29 22 AM Screenshot 2024-11-25 at 10 29 32 AM Screenshot 2024-11-25 at 10 32 46 AM

The asset selectors treat ICX as though it's wICX, as it should be above sICX when the list is ordered alphabetically. Screenshot 2024-11-25 at 10 28 39 AM

When you choose ICX, can we make the second asset default to sICX instead of bnUSD?

Also, shouldn't we be able to stake LP tokens for the new pool? Screenshot 2024-11-25 at 10 36 59 AM

hetfly commented 1 day ago

@parrot9design thanks!

We will have to keep wICX in the URL as long as the queue is still active

When you choose ICX, can we make the second asset default to sICX instead of bnUSD?

I'd rather not, we would have to check if user previously used the the other selector so that we wouldn't be overwriting their previous choice. But we could set the ICX/sICX as the new default pool instead. It will have the highest APR for a while anyway, I think, and will be the main reason for users visiting the supply tab.

Also, shouldn't we be able to stake LP tokens for the new pool?

The option to stake is for pairs with incentives only, there are none for this pool yet.