search

balancer / balancer-core

Balancer on the EVM
GNU General Public License v3.0
333 stars 169 forks source link

Add LIMIT_IN and LIMIT_OUT for joinswap/exitswap #214

Closed FernandoMartinelli closed 4 years ago

FernandoMartinelli commented 4 years ago

Applying the same limits for joinswap and exitswap as the pure swap functions

FernandoMartinelli commented 4 years ago

Sure, will work on it today or tomorrow 👍

On Sun, Feb 2, 2020, 10:17 Mike McDonald notifications@github.com wrote:

@mikemcdonald requested changes on this pull request.

The exitswapPoolAmountIn test in math_extreme_weights fails with the new enforced ratios. Can you update that and re-push?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/balancer-labs/balancer-core/pull/214?email_source=notifications&email_token=AAM72WXQD7367S63CSQSFO3RA3P2PA5CNFSM4KMGSOG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT5E3UA#pullrequestreview-351948240, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM72WSF7PSCXTKI3FLR7N3RA3P2PANCNFSM4KMGSOGQ .