balancer / balancer-deployments

GNU General Public License v3.0

41 stars 35 forks source link

Deployment preparation: `ChainlinkRateProviderFactory` #67

Closed 0xSpraggins closed 1 year ago

0xSpraggins commented 1 year ago

Deployment preparation: `ChainlinkRateProviderFactory`

Build-info: https://github.com/balancer/metastable-rate-providers/commit/8793212b2567b2df81d6162bcb125067a5cd4ba1

Deployment preparation tasks checklist:

[x] Deployments README is updated with the new task name and link
[x] Task README has a description and links to the artifacts
[x] build-info is updated with artifacts compiled at the specified commit
[x] Artifacts are generated from build-info
[x] New task has a working fork test

Code checklist:

[x] The diff is legible and has no extraneous changes
[x] Complex code has been commented in tests and scripts
[x] Fork test block number and test cases are appropriate for this deployment
[x] The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

0xSpraggins commented 1 year ago

Looks pretty good! I've verified that the build info matches with the one generated by balancer/metastable-rate-providers@8793212.

I've left a bunch of comments to simplify the test a bit, also matching the style of the rest of the tests. Other than that, it's good to go; great work!

@jubeira Thanks for mentioning the tools to get the contract instance using its name. Ive made the suggested changes. Should be good to go now.