jubeira commented 1 year ago

Deployment preparation: `StakelessGaugeCheckpointer`

Build-info: https://github.com/balancer/balancer-v2-monorepo/commit/ea262dc756e99745c884383b95d3ed512ae3ef9d (master).

Edit: a last minute feature was added to the contract, and the build-info was modified in #72.

Deployment preparation tasks checklist:

[x] Deployments README is updated with the new task name and link
[x] Task README has a description and links to the artifacts
[x] build-info is updated with artifacts compiled at the specified commit
[x] Artifacts are generated from build-info
[x] New task has a working fork test

Note: the task has two fork tests. The base case should be identical to the one in the 20230527-l2-gauge-checkpointer task, proving that the new version can still do the same. The second one tests a corner case that was not covered by the original version.

Deprecating old tasks checklist:

[x] Old task was moved to deprecated/ directory
[x] Deployments README is updated: old task is moved to the 'deprecated' section, and links are updated with the deprecated/ prefix
[x] Old task imports in index.ts, input.ts and fork tests are updated
[x] Old task README is updated with a warning sign, a link to the replacement task and a short description

Code checklist:

[x] The diff is legible and has no extraneous changes
[x] Complex code has been commented in tests and scripts
[x] Fork test block number and test cases are appropriate for this deployment
[x] The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

EndymionJkb commented 1 year ago

I confirm that the build-info matches.

jubeira commented 1 year ago

Did it always do this "dismiss stale review" thing on every change, or did we just add that?

It's a setting that was turned on for the deployments repo when it was set up (does not happen in the monorepo).

It's a bit annoying, but it also ensures that you cannot change the build info and go unnoticed. So I'm inclined to keeping it.

balancer / balancer-deployments