balancer / balancer-deployments

GNU General Public License v3.0
41 stars 35 forks source link

Add Fantom deployments #74

Closed EndymionJkb closed 1 year ago

EndymionJkb commented 1 year ago

Deployment: Add Fantom deployment addresses

This is partially to support Balpy, which queries this repo. Imported existing Fantom deployments (e.g., the Vault), along with a few additions to conform to other network deployments (e.g., test BAL token for mock pools). Also added configuration required for CI.

Doesn't work for the original purpose, since some contracts were modified. Nevertheless, this has value for capturing the Fantom configuration - and validating that the very basic contracts (e.g., the Vault) are legit.

Supersedes #70

Deployment tasks checklist:

Issue Resolution

franzns commented 1 year ago

Hey @EndymionJkb

thanks a lot for this! What do you need from me? We have other deployments on Fantom as well, like all previous iterations of weighted and composable pools, but I don't think we want to include these, do we?

EndymionJkb commented 1 year ago

Hey @EndymionJkb

thanks a lot for this! What do you need from me? We have other deployments on Fantom as well, like all previous iterations of weighted and composable pools, but I don't think we want to include these, do we?

Anything in active use should be verified here; I mainly wanted to make sure we aren't missing other contracts, beyond previous versions of pools. Balpy only uses the main versions, so this is already enough to support that.

The other purpose of this, though, is to provide action ids and verify the build-info matches what's actually deployed (e.g., that Beets didn't change the code of anything before deploying).

If the "old" pools have all been migrated, and their pause windows are expired, etc., such that we don't need the action ids, I guess it's ok to leave them out. But anything in current use, or that we might need to call a permissioned function on, should be included.