See this PR in the monorepo, which fixes an obscure issue with the BaseSplitCodeFactory where, if you were very unlucky indeed, the second half of the contract might start with valid opcodes including a selfdestruct, which would brick the factory if executed.
This adds fork tests to all the pool factories, checking that this did not already happen, and should be carried forward into any future pool deployments (with corrected factory code, if it's a new release and not a patch).
Type of change
[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[X] Other
Checklist:
[X] The diff is legible and has no extraneous changes
[N/A] Complex code has been commented, including external interfaces
[X] Tests are included for all code paths
[X] The base branch is either master, or there's a description of how to merge
jamiegreen7
commented
1 year ago
Description
See this PR in the monorepo, which fixes an obscure issue with the BaseSplitCodeFactory where, if you were very unlucky indeed, the second half of the contract might start with valid opcodes including a selfdestruct, which would brick the factory if executed.
This adds fork tests to all the pool factories, checking that this did not already happen, and should be carried forward into any future pool deployments (with corrected factory code, if it's a new release and not a patch).
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution