search

balancer / balancer-exchange

Exchange dapp for token swaps
https://balancer.exchange
GNU General Public License v3.0
95 stars 104 forks source link

Migrate to ethers v5 #127

Closed TomAFrench closed 4 years ago

TomAFrench commented 4 years ago

I've gone through and moved everything over to point at ethers v5.

This has allowed me to remove UncheckedJsonRpcSigner as ethersv5 handles this natively.

TomAFrench commented 4 years ago

The current multicall abi is causing errors due to a conflict of the aggregate function being marked as both constant and nonpayable. I've added a fix for the abi in this repo although the same error occurs in calls to @balancer-labs/sor so this can't be merged until changes have been made to that repo as well.

bonustrack commented 4 years ago

Thank you for your contributions @TomAFrench that's incredibly helpful we will review them shortly.

bonustrack commented 4 years ago

@TomAFrench We've just published a new version of @balancer-labs/sor, the v0.3.3, that include your contribution to upgrade to ethers.js v5, thank you again for your contribution! Now that sor pkg is updated we can go forward with this PR, do you want to update your PR and resolve conflicts or do you prefer if i do it?

TomAFrench commented 4 years ago

Hey @bonustrack. No worries about the PR, it's a super small thing. I've noticed that you've already started on #150 so I'm going to leave this one be.

bonustrack commented 4 years ago

@TomAFrench Thank you and sorry for the hurry!