balancer / balancer-v2-monorepo

Balancer V2 Monorepo
https://balancer.fi/
GNU General Public License v3.0
315 stars 382 forks source link

Fix `BalancerErrors` compiler range #2520

Closed jubeira closed 1 year ago

jubeira commented 1 year ago

Description

BalancerErrors doesn't actually compile with 0.7.0. We need the first feature listed in the release notes for 0.7.1.

Another option would be not using "free functions", but at this point I think it's just not worth it.

Type of change

Checklist:

Issue Resolution

N/A

jubeira commented 1 year ago

Probably nobody is using exactly 0.7.0, which is why we never encountered this, and maybe this is overkill: but it's not wrong to fix it.

Here's how I realized :) https://github.com/publu/qidao_gov/pull/1

jubeira commented 1 year ago

Thanks for remembering the changelog - I'm not sure we always do that.

We'll do one more pass over it before the next npm release.