search

balancer / balancer-v3-monorepo

GNU General Public License v3.0
38 stars 15 forks source link

Batch router: BPT transfers and approvals #531

Open jubeira opened 5 months ago

jubeira commented 5 months ago

We're calling bpt.approve and bpt.transfer in some instances in the batch router. This is kinda inefficient because BPTs are actually facades that call the vault, which in fact calls the extension. So the chain is router --> BPT --> vault --> vault extension.

Can we move the external methods for transfer and approve from the extension to the vault, and then call the vault directly instead of using the BPT facade? In that case, the call chain would be router --> vault.

EndymionJkb commented 3 months ago

Is this obsolete now that we have permit2, infinite self-allowance, etc.?