DRAFT: Optimize EnumerableMap to not load size

[elshan-eth]

Description

Maybe it is a strange idea, but what if we will store the length in the first element and pack it in one slit with an address?

Type of change

• [ ] Bug fix
• [ ] New feature
• [ ] Breaking change
• [ ] Dependency changes
• [ ] Code refactor / cleanup
• [ ] Documentation or wording changes
• [ ] Other

Checklist:

• [ ] The diff is legible and has no extraneous changes
• [ ] Complex code has been commented, including external interfaces
• [ ] Tests have 100% code coverage
• [ ] The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #116

[jubeira]

This is pretty smart, thanks @elshan-eth.

I think the original point was to play around the idea that the maximum token amounts is 4, but if I'm not mistaken not knowing the actual length doesn't play along nicely with unchecked_At, and using the safe version would defeat the purpose?

I'm not against this one, but I'd like to import the original tests from OZ and test our modified implementation against it if possible.

[elshan-eth]

@jubeira, yes, we still need to know the length since we use it to fill arrays (PoolDataLib.load). We don't use safe operations because they are more expensive than unchecked_At.

[elshan-eth]

We have the same tests as openzeppelin tests in test/EnumerableMap.test.ts