Add example immutable/mutable getters.

[johngrantuk]

Description

Adds new getters: getMutableData to PoolInfo and getImmutableData to Stable/Weighted pools. Goal was to try and:

• Have common interfaces to retrieve required data for calculating offchain swaps/adds/removes. Makes it a bit easier for external integrators to figure out which calls are required for which pools.
• Reduces required RPC calls (or use of multicall), particularly for refetching mutable data for up to date calculations Ideally we would try to encorage new pool developers to implement these.

Type of change

• [ ] Bug fix
• [ ] New feature
• [ ] Breaking change
• [ ] Dependency changes
• [ ] Code refactor / cleanup
• [ ] Documentation or wording changes
• [ ] Other

Checklist:

• [ ] The diff is legible and has no extraneous changes
• [ ] Complex code has been commented, including external interfaces
• [ ] Tests have 100% code coverage
• [ ] The base branch is either main, or there's a description of how to merge

Issue Resolution

[jubeira]

Thanks @johngrantuk!

I'm not against adding this, but I do see a few issues:

• The interface is not the same across different pool types, so you'll need to know the pool type you're dealing with when calling the function. You could get around this by encoding the pieces that are different across pools in a bytes array, but you'd still need to know how to decode it which is probably even more annoying.
• We just can't force pool devs to include an interface like this; it's even more unclear due to the fact that the interface definition can't be normalized.

If you think it's still worth it to have it without any sort of common base interface we can proceed like this anyways. Thoughts? @danielmkm

[danielmkm]

I did a bit of a refactor here.

• Changed the functions to return structs
• Renamed the functions to have unique namespaces
• Moved both dynamic and immutable function to the pool contract level

[johngrantuk]

I did a bit of a refactor here.

* Changed the functions to return structs

* Renamed the functions to have unique namespaces

* Moved both dynamic and immutable function to the pool contract level

Thanks for this. It works for me 🙏

[jubeira]

This should be ready for one last review before :ship:

[openzeppelin-code[bot]]

Add example immutable/mutable getters.

Generated at commit: 3094a9f5ebac5e9c5d9c493248b068861f03d31c

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 2 0 11 37 52
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector