balancer / balancer-v3-monorepo

GNU General Public License v3.0
24 stars 4 forks source link

Remove unused HooksConfigLib arguments #698

Closed EndymionJkb closed 1 week ago

EndymionJkb commented 1 week ago

Description

Little one to address a consequence of merging Hooks and Pool configs and remove distracting warnings. Saves a little gas, too.

Type of change

Checklist:

Issue Resolution

EndymionJkb commented 1 week ago

Why not just remove the argument and make a regular library call?

I'd just do HooksConfigLib.callComputeDynamicSwapFeeHook(swapParams, staticSwapFeePercentage, ...);

I had it like that originally, but didn't want to break the pattern of the others (since some do use the argument). Can see what it looks like that way.

openzeppelin-code[bot] commented 1 week ago

Remove unused HooksConfigLib arguments

Generated at commit: a4c9a8149f79fcda17c53c850f0abdd53fe3c0f5

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
11
37
52
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector