balancer / balancer-v3-monorepo

GNU General Public License v3.0
24 stars 4 forks source link

Fix coverage reports #710

Closed joaobrunoah closed 1 week ago

joaobrunoah commented 1 week ago

Description

Coverage reports doesn't work with via-IR flag enabled, so a few changes are required:

Type of change

Checklist:

joaobrunoah commented 1 week ago

Cool! Sounds reasonable.

Can we have just a single coverage.sh script though? We had one in the root and symlinks inside each package before. Is there any reason to actually copy the content of the script in every package?

I can try to use the same coverage.sh, but as you can see in the PR, they're slightly different. I will try adding a few inputs to the sh file.

joaobrunoah commented 1 week ago

Looks like it works, even at the top-level.

It looks like we're back to a single script with soft links, so you can remove "Each pkg should have its own coverage.sh" from the description.

Also, it leaves the info-e files behind. Do we want that? If so, should add to the .gitignore

info-e files are added to .gitignore. I just left them because it's easier to debug lcov.info edits with the info-e file, in case something fails.