balancer / balancer-v3-monorepo

GNU General Public License v3.0

24 stars 4 forks source link

DRAFT fix for cleaning vars after operations in Batch Router #718

Closed elshan-eth closed 1 week ago

elshan-eth commented 1 week ago

Description

Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other

Checklist:

[ ] The diff is legible and has no extraneous changes
[ ] Complex code has been commented, including external interfaces
[ ] Tests have 100% code coverage
[ ] The base branch is either main, or there's a description of how to merge

Issue Resolution

openzeppelin-code[bot] commented 1 week ago

DRAFT fix for cleaning vars after operations in Batch Router

Generated at commit: 640a795e935d73f25a1762e63cda6bd1477ee204

🚨 Report Summary

Severity Level Results

Contracts Critical
High
Medium
Low
Note
Total 2
2
0
11
37
52

Dependencies Critical
High
Medium
Low
Note
Total 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 2 0 11 37 52
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

elshan-eth commented 1 week ago

This way turned out to be expensive, even if we optimized getting a slot.