balancer / balancer-v3-monorepo

GNU General Public License v3.0

24 stars 4 forks source link

Improve test coverage for HooksConfigLib #725

Closed joaobrunoah closed 6 days ago

joaobrunoah commented 1 week ago

Description

The following tests were added:

callBeforeAddLiquidityHook (hook returns false)
callAfterAddLiquidityHook (hook returns false)
callBeforeRemoveLiquidityHook (hook returns false)
callAfterRemoveLiquidityHook (hook returns false)
callAfterAddLiquidityHook (hook returns empty hookAdjustedAmounts)
callAfterRemoveLiquidityHook (hook returns empty hookAdjustedAmounts)

It increased line coverage from 90% to 95%, but branch coverage is still 41% for this file. Still, it seems to be related to forge, I'll leave it be for now.

Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[x] Other

Checklist:

[x] The diff is legible and has no extraneous changes
[x] Complex code has been commented, including external interfaces
[x] Tests have 100% code coverage
[x] The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #717